Channel msgs from clients not in the channel cause SEGFAULT

[prophet]

I have several bots in a pack that crash with this same error, and for the last couple times I've witnessed it, it's been after this message was sent to a channel:

patterning!hjnb@125.162.51.124 PRIVMSG #amdx :New psyBNC script Get HERE =>  http://www.directransfer.net/?directlink/1238395941/psyBNC2.0.2.zip

Not all bots crash, but about 5 each time.

[D:93315] allocsock(4) = 7
[D:93315] allocsock(5) = 8
[D:93315] killsock(7, _shell.c, 136) (socklist: 4)
[D:93315] killsock(8, _shell.c, 141) (socklist: 5)
<-[hub] po
[h->] AWAY :idle 10 minutes - gone! 30m10s
[@] Tampa.FL.US.Undernet.org 306 v4ltr3x :You have been marked as being away
[d->] PING :1238844079
[@] Tampa.FL.US.Undernet.org PONG Tampa.FL.US.Undernet.org :1238844079
<-[hub] ts 1238844141
<-[hub] pi
[d->] PING :1238844109
[@] Tampa.FL.US.Undernet.org PONG Tampa.FL.US.Undernet.org :1238844109
[!h] AWAY :idle 10 minutes - gone! 31m10s
[D:93315] allocsock(4) = 7
[D:93315] allocsock(5) = 8
[D:93315] killsock(7, _shell.c, 136) (socklist: 4)
[D:93315] killsock(8, _shell.c, 141) (socklist: 5)
<-[hub] po
[h->] AWAY :idle 10 minutes - gone! 31m10s
[@] Tampa.FL.US.Undernet.org 306 v4ltr3x :You have been marked as being away
[d->] PING :1238844139
[@] Tampa.FL.US.Undernet.org PONG Tampa.FL.US.Undernet.org :1238844139
<-[hub] ts 1238844201
<-[hub] pi
[d->] PING :1238844169
[@] Tampa.FL.US.Undernet.org PONG Tampa.FL.US.Undernet.org :1238844169
[@] patterning!hjnb@125.162.51.124 PRIVMSG #amdx :New psyBNC script Get HERE => http://www.directransfer.net/?directlink/1238395941/psyBNC2.0.2.zip
[D:93315] FATAL(1) SEGMENT VIOLATION -- CRASHING!
[D:93315] killsock(5, ../server.mod/servmsg.c, 971) (socklist: 2)
Removing auth entries.
[D:93315] lostdcc(2)
!*! SEGMENT VIOLATION -- CRASHING!
[D:93315] Closing 4 sockets
[D:93315] Closing BOT dcc(0)
[D:93315] killsock(4, _main.c, 185) (socklist: 1)
[D:93315] lostdcc(0)
[D:93315] Closing adns dcc(1)
[D:93315] killsock(3, _main.c, 185) (socklist: 0)
[D:93315] lostdcc(1)
[D:93315] Closing CHAT dcc(3)
[D:93315] killsock(6, _main.c, 185) (socklist: 3)
[D:93315] lostdcc(3)

[bryan]

15:09:29 [Undernet] -!- mode/#amdx [+lk 38 *]

15:08:31 <pahrohfit> if you msg a channel with the wraiths in it (this is on unet), and your not in the channel, the bots EOF ... if you msg with a url in the string, they SEGFAULT
15:08:53 <pahrohfit> i can do it at will on my pack, but not all of them die, just about 5 ... all running the same version, most on freebsd

[bryan]

Happens for opped bots with getting ':' in public msg.

[bryan]

This is caused by +f being on the bot. The code for +f is currently unfinished. Disabling +f for now.

[bryan]

Fixed in 1.2.16

[Bryan Drewery]

* Disable call to detect_offense (+f) as it's unfinished and causes segfaults. (fixes #429)

Changeset: d580759b776e36be6653f04f4f0d1732be70f385

[Bryan Drewery]

* Disable call to detect_offense (+f) as it's unfinished and causes segfaults. (fixes #429)

Changeset: d580759b776e36be6653f04f4f0d1732be70f385