Follow me on twitter

Ticket #369 (closed defect: fixed)

Opened 3 years ago

Last modified 15 months ago

Linking to unexpected bots causes causing failed links

Reported by: bryan Owned by: bryan
Priority: normal Milestone: 1.2.16
Component: botnet Version: 1.2.14
Keywords: link botlink enclink Cc:

Description 

net: connect(4, 69.64.32.40, 34248)
[D:51618] Choosing 'ghost+case2' (6/0) for link
kyle failed encrypted link handshake
[D:51618] killsock(4, _dcc.c, 391) (socklist: 1)

net: connect(4, 69.64.32.40, 34248)
[D:51618] Choosing 'ghost+case2' (6/0) for link
chadd failed encrypted link handshake
[D:51618] killsock(4, _dcc.c, 391) (socklist: 1)

net: connect(4, 69.64.32.40, 34248)
[D:51618] Choosing 'ghost+case2' (6/0) for link
Handshake with allen succeeded, we're linked.
Linked to botnet.
[D:51618] botpval: 01allen

net: connect(4, 69.64.32.40, 34248)
[D:57101] Choosing 'ghost+case2' (6/0) for link
daniel failed encrypted link handshake
[D:57101] killsock(4, _dcc.c, 391) (socklist: 1)
[D:57101] lostdcc(0)

only Pass: allen

Solved:

allen is main hub All other hub dns points to allen.

Bot links expecting 'daniel' but gets 'allen' and fails.

Change History

Changed 3 years ago by bryan

Solution:

  • Make hub say what bot it is on link.
  • If connecting leaf expected another, make leaf fail out
  • Have hub put notice out that connecting leaf expected another hub.

Changed 3 years ago by plat0nic

my bad
didn't realize the complications involved

Changed 3 years ago by bryan

  • priority changed from blocker to critical
  • status changed from new to assigned
  • type changed from defect to enhancement

Changed 3 years ago by bryan

  • priority changed from critical to trivial

Changed 3 years ago by bryan

  • summary changed from Failed encrypted link handshake in 1.2.14 3545 to Linking to unexpected bots causes causing failed links

Changed 15 months ago by bryan

  • priority changed from trivial to normal
  • type changed from enhancement to defect

Changed 15 months ago by Bryan Drewery

  • status changed from assigned to closed
  • resolution set to fixed

* Fix bots linking to the wrong hub not giving a good reason why they failed in the log. (fixes #369)

Changeset: 046177b780e1db962d0ffdb06f1acdd110064f20

Changed 15 months ago by Bryan Drewery

Merge branch 'link-wrong-hub'

* link-wrong-hub:

  • Only check expected nick if provided
  • Fix bots linking to the wrong hub not giving a good reason why they failed in the log. (fixes #369)

Conflicts:

doc/UPDATES

Changeset: fd14c83a008095561de45af03553623663c06fa3

Note: See TracTickets for help on using tickets.