Follow me on twitter

Ticket #268 (closed defect: fixed)

Opened 4 years ago

Last modified 10 months ago

chanban trimming

Reported by: sknake Owned by: bryan
Priority: trivial Milestone: 1.3
Component: cmds Version: 1.2.10
Keywords: Cc:

Description

Can you trim the spaces after the host? if i do *!*@host.com<space><space>#chan then it uses that for the comment rather than validating it as a channel. this is highly annoying since copy/paste is my method of choice. 

[14:42] <warjest> .+ban *!*@test123.com  #kuwait
[14:42] <usual> [18:43] #warchest# (GLOBAL) +ban *!*@test123.com ( #kuwait)
[14:42] <usual> New ban: *!*@test123.com ( #kuwait)
[14:42] <usual> Saving userfile...

Change History

follow-up: ↓ 2   Changed 4 years ago by bryan

  • keywords .+ban removed
  • milestone changed from 1.2.11 to 1.3.0

This bug actually affects all cmds over dcc. It'll be fixed in 1.3.x or 2.0

in reply to: ↑ 1   Changed 10 months ago by bryan

Replying to bryan:

This bug actually affects all cmds over dcc. It'll be fixed in 1.3.x or 2.0

Not sure what I was thinking, but that's not the case. This is due to newsplit(). A global fix makes the most sense to ignore excess spaces, but may have a huge negative impact in some places.

  Changed 10 months ago by bryan

  • milestone set to 1.2.17

  Changed 10 months ago by Bryan Drewery

  • status changed from new to closed
  • resolution set to fixed

* Cleanup all string parsing to trim excess whitespaces (fixes #268)

Changeset: 217d10954c642c3649525daba4cf958c41c3c5fe

  Changed 10 months ago by Bryan Drewery

* Cleanup all string parsing to trim excess whitespaces (fixes #268)

Changeset: 217d10954c642c3649525daba4cf958c41c3c5fe

  Changed 10 months ago by Bryan Drewery

Merge branch '268-whitespace'

* 268-whitespace:

  • Cleanup all string parsing to trim excess whitespaces (fixes #268)

Changeset: 8a159be8bd2a8c767c95e3cc2c46b4b450dc6b8f

  Changed 10 months ago by Bryan Drewery

Merge branch '268-whitespace'

* 268-whitespace:

  • Cleanup all string parsing to trim excess whitespaces (fixes #268)

Changeset: 8a159be8bd2a8c767c95e3cc2c46b4b450dc6b8f

Note: See TracTickets for help on using tickets.