botcmd results flood to stale idx

[sknake]

if you do something like ".page 1" and then do a command that spawns a lot of responses, i.e. ".bc * channel #somebigchan"

when you do .relay <blah> to the same bot that booted you, it automatically starts outputting the data to your session even though you hadn't authenticated to the bot you're trying to relay to

[01:13] <disc> <x0wner@hub> damn it just flooded the hell out of me when i typed .relay hub

evidently it floods other users that attempt to connect to that bot as well

[bryan]

booted?

[sknake]

booted = kicked from partyline. i guess if too much sendq builds up it kicks you from the partyline? I can't remember exactly what the case was.

[bryan]

wraith wrote:
> #208: .page bug
> ---------------------+------------------------------------------------------
>   Reporter:  sknake  |       Owner:  bryan 
>       Type:  defect  |      Status:  new   
>   Priority:  minor   |   Milestone:  1.2.11
>  Component:  botnet  |     Version:  1.2.9 
> Resolution:          |    Keywords:        
> ---------------------+------------------------------------------------------
> Comment (by sknake):
>
>  booted = kicked from partyline. i guess if too much sendq builds up it
>  kicks you from the partyline? I can't remember exactly what the case was.
>
>   
word

[sknake]

[16:04] <warjest> .page 5
[16:04] <usual> Paging turned on, stopping every 5 lines.
[16:04] <usual> [20:04] #warchest# page 5
[16:04] <usual> Console setting stored.
[16:04] <usual> Saving userfile...
[16:04] <warjest> .bc & channel #kuwait
[16:04] <usual> [20:04] @ #warchest# [bc -> botcmd ] ...
[16:04] <usual> [20:04] #warchest# botcmd & channel ...
[16:04] <usual> [20:04] (natty) #warchest# (#kuwait) channel
[16:04] <usual> [natty] Channel #kuwait, 173 members, mode +psmtnl 175:
[16:04] <usual> [natty] Channel Topic: A store near you http://clicknbuy.com.kw/
[16:04] <usual> [natty] (n = owner, m = master, o = op, d = deop, b = bot) CAP:global
[16:04] <usual> [natty]  NICKNAME  HANDLE     JOIN    HOPS IDLE  USER@HOST USER@IP
[16:04] <usual> -=- poof -=-
[16:04] <usual> You've been booted from the bot by hub: too many pages - senq full
[16:04] <usual> *** RELAY CONNECTION DROPPED.
[16:04] <usual> You are now back on usual
[16:04] <usual> *** warchest rejoined the party line..
[16:04] <usual> *** (hub) warchest has left the party line (hub booted warchest from the party line: too many pages - senq full).
[16:04] <warjest> .relay hub
[16:04] <usual> #warchest# relay hub
[16:04] <usual> (Type *BYE* on a line by itself to abort.)
[16:04] <usual> Success!
[16:04] <usual> NOW CONNECTED TO RELAY BOT hub ...
[16:04] <usual> (You can type *BYE* to prematurely close the connection.)
[16:04] <usual> *** warchest left the party line.
[16:04] <usual> [atari]  +Cigarette *         06Sep     3 19h  Cigarette@adsl75-252.quaIitynet.net 
[16:04] <usual> [atari]  +cody3     *         06Sep     3 16h  freebsd@my.harddrive.is.bigger.than-yours.net 
[16:04] <usual> [atari]  @compliant compliant  ---  B   5  1d  lcruzer@posix.us 
[16:04] <usual> [atari]  +Cont      *         13:34     4  6h  asd@hoas-fe37dd00-208.dhcp.inet.fi 
[16:04] <usual> [atari]  @convey    convey    15:38 B   5  4h  matrix@69.50.185.123 
[16:04] <usual> [atari]  @coop-     skurred   12:27 B   4  3h  ~skurred@afraid.bz 
[16:04] <usual> [atari]  +cracked   *         19:59     -1  4m  cracked@cpe-238-108-31-26.nyc.res.rr.com 
[16:04] <usual> [atari]  +d3mi6     *          ---      4  1d  earth@laugh.at.the-us-gov.us 
[16:04] <usual> [atari]  @datakill  datakill  06Sep B   5 20h  sk@66.252.21.135 
[16:04] <usual> [atari]  +Dentist   *         19:43     -1 21m  ok@62.150.161.85 
[16:04] <usual> [atari]  +dev`      *         06Sep     4  1d  cadet@208.98.35.61 
[16:04] <usual> [atari]  @discus    discus     ---  B   4      stable@stable.irchost.net 
[16:04] <usual> [atari]  +divan     tempop     ---  o   4  9h  fugitive@dont.be.c0nfused.info 
[16:04] <usual> [atari]  +Dmm       *          ---      4 20h  mcdonalds@cocaine.drug-lord.net 

[bryan]

I can't recreate this..

[bryan]

(In [3725]) * Cleanup page code (addresses #208)

[bryan]

(In [3726]) * Port [3725] to 1.2.15

• Cleanup page code (addresses #208)

[bryan]

Finally recreated this, after 3 years. Wow.

Flooded on connect to telnet, without ever even typing a username.

[bryan]

Ok, this has nothing to do with paging.

It's the botcmd results being flooded to the same idx (dcc id) as requested. It's not actually buffering up this data anywhere, it's simply still coming in from the remote bot.

[Bryan Drewery]

* Fix botcmd to make sure that results are delivered only to the requester (fixes #208)

Changeset: 1fe7967f3db944174ec6ebbebcd6b1ffc733efb4

[Bryan Drewery]

Merge branch '208-botcmd-stale-idx' into next

* 208-botcmd-stale-idx:

• Fix botcmd to make sure that results are delivered only to the requester (fixes #208)

Conflicts:

doc/UPDATES

Changeset: 994e90208a63bdea36b78024f88e32faf73d8261

[Bryan Drewery]

Merge branch '208-botcmd-stale-idx'

* 208-botcmd-stale-idx:

• Fix botcmd to make sure that results are delivered only to the requester (fixes #208)

Changeset: b98a586fd941145afd262d443f32d6805569ab84